Discord Name: nottherealtar
GitHub Repository (Must be V3): GitHub - nottherealtar/TarsOnlineCogs: Cogs for my Redbot v3 instances
Description: This is a collection of cogs that I have made over time, some of them are just fun little projects or things I’ve found. It also showcases the wide use cases of various red v3 functions. Some are duck-taped together but it’s fine, we have the community support xD
Hi nottherealtar, I will begin to review your repository in the coming weeks. Thanks for your patience 
Thank you for your patience whilst I reviewed your repository. You have shown that you have a strong foundation of knowledge for the discord.py library, and a moderate show of knowledge for Red’s library and internal API. Once you implement the necessary changes from this review, I am happy to mark this repository as approved and assign you as Cog Creator. If you have any queries about this review, please send me a message on Discord.
It seems that many of your cogs’ functionalities are tailored towards a specific bot. In some cases, this is completely breaking commands, or branding the cog for your bot, and not for the bots of the bot owners who are installing your cogs. Things to consider:
There are also cases where you have cached the cog’s settings instead of using the Config framework. In this case, settings will reset every time the cog is unloaded/reloaded or when the bot is restarted or shut down. This is an inconvenience for users and should be changed.
Please ensure that you check permissions. This includes command decorators and inside commands, such as to delete messages. This is to prevent unpriviledged users exploit permission escalation and cause unwanted behaviour in your cog.
Your repository is missing a required info.json file. This resides in the
root of your repository, and consists of keys used to give information to users
about your repository. It must contain author, short and description
keys. For more information, please read here.
Cog package names should typically use lower case by convention. I advise you
change the package name to infinicount or a reasonable alternative.
checks module has been deprecated for some time, all command check decorators are now available directly from redbot.core.commands.setup function must be asynchronous, and bot.add_cog must now be awaited, following the new format introduced in Red 3.5. Please make this amendment so I can test the functionality of the cog. The min_bot_version key in your info.json file says "3.5.0", but the cog is currently ineligible for this version.name is the TitleCase name of your cog, not lower case.I understand this cog is a work in progress, but I still have taken a small look.
redbot.core, and then using the Config.get_conf classmethod. See the config framework for more information.pass statement will work here.name is the TitleCase name of your cog, not lower case.This cog has clearly been archived, so I won’t take a look at this. You should remove it from your main branch.
name is the TitleCase name of your cog, not lower case.r"", or use the backslash twice each time, to escape the backslash itself.name is the TitleCase name of your cog, not lower case.I am really impressed by this cog, great work! Good use of bundled_data_path too.
checks module has been deprecated for some time, all command check decorators are now available directly from redbot.core.commands.name is the TitleCase name of your cog, not lower case.checks module has been deprecated for some time, all command check decorators are now available directly from redbot.core.commands.update command, and could be moved to a separate method to avoid code repetition (optional).name is the TitleCase name of your cog, not lower case.It appears the majority of code from this cog has been taken from aikaterna’s rndstatus, and no credit has been given. It is very important to respect the licenses of other repositories if you are using their code directly or with small modifications. You can credit others through the author key in your info.json file. You should check with aikaterna if you are able to use this code.
checks module has been deprecated for some time, all command check decorators are now available directly from redbot.core.commands.cog_unload method needs to be asynchronous and the presence_task.cancel() needs to be awaited.name is the TitleCase name of your cog, not lower case.setup function should be removed, as it is defined asynchronously in __init__.py.name is the TitleCase name of your cog, not lower case.name is the TitleCase name of your cog, not lower case.This file is unused and should probably removed until it is implemented for production.
name is the TitleCase name of your cog, not lower case.discord.NotFound exception. You should use a try/except block here.bot.wait_for will raise asyncio.TimeoutError is a response is not given within the given or default timeout. You should wrap this operation in a try/except block, and cancel or assume the part if asyncio.TimeoutError is raised.name is the TitleCase name of your cog, not lower case.altcheck does not belong to this cog. If you wish to interact with external cogs, you should add the external cog to the required_cogs key inside your info.json file.bot.get_context with invoke seems illogical. Instead, you could define a separate function that generates the results you want, so you can pass it to target_channel.send without the need for external functionality and the need to get context from the member object.logging module to log errors to the console.status argument?@commands.command(name="autoscan")
async def toggle_check(self, ctx, status: bool):
"""Toggle autoscan."""
self.auto_check = status
await ctx.send(f"Auto-Scan {'enabled' if status else 'disabled'}.")
name is the TitleCase name of your cog, not lower case.redbot.core.commands. You should check permissions (location.permissions_for) for the bot so that they can create the role.redbot.core.commands. You should check permissions (location.permissions_for) for the bot so that they can create the role.pagify and box utilities from redbot.core.utils.chat_formatting here.name is the TitleCase name of your cog, not lower case.verifyall, a separate cog on your repository. However, as a public cog, it may be better if this cog facilitated a command to figure the role they’d like, and then store the role ID in the guild’s Config.This cog uses requests, which is blocking. This means that other processes cannot run concurrently until the requests operation is finished. Instead, you should use aiohttp. Initialise aiohttp.ClientSession() in your cog’s __init__, and use asynchronous context managers to retrieve information. Don’t forget to close the session in your cog’s cog_unload method. There are plenty of examples of aiohttp usage within the community if you need some assistance.
name is the TitleCase name of your cog, not lower case.The data in this file appears to reflect information about 2 different cogs, but not the ThankYou cog.
commands.UserFeedbackCheckFailure and its subclasses are raised.VerifyAll, not teachme.