Added joinping which simply ghost pings recently joined members in multiple channels of thed user’s choice to alert them about the existence/purpose of that channel (for example a react role channel to get react role etc)
Once your repo is updated to support 3.5 on the default branch, please make a comment in this thread to confirm you are once again ready for review. We will only be reviewing repos which comment to confirm 3.5 support, but we will prioritize repos that have been in the queue for a longer period of time first.
If you wish to revoke your application, please comment accordingly so we can clean up the thread. If you need time to make changes, but are actively working on making updates, please also comment accordingly. Applications which do not see any activity within 1 month from today will be closed.
Commit at time of review: 9aefcb55c7bd47993d311ccd400abca8686b6460
General Notes:
May want to update author field in cogs due to Pomelo.
Some places make reference to the User/Member object which includes #0 discriminator if they have opted-in to Pomelo (Take a look at dpy2.3 changes, most of these will fix with that. Just a heads-up).
hitormiss:
You might want to replace fuzzywuzzy, as it is no longer maintained. I would suggest rapidfuzz.
fuzzywuzzy is not listed in requirements for this cog, but is imported.
hitormiss createitem create errors on all usages:
[21:00:22] ERROR [red] Exception in command 'hitormiss createitem'
╭───────────────────────────────────────── Traceback (most recent call last) ──────────────────────────────────────────╮
│ datapath\Red-DiscordBot\.venv\lib\site-packages\discord\ext\commands\core.py:229 in wrapped │
│ ❱ 229 ret = await coro(*args, **kwargs) │
│ Red-DiscordBot\data\flare\cogs\CogManager\cogs\hitormiss\main.py:456 in │
│ hom_create │
│ ❱ 456 if functools.reduce(lambda x: x.lower() == name.lower(), self.items.keys()): │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
TypeError: <lambda>() takes 1 positional argument but 2 were given
throw has two default None args. The command just shows help with no helpful message indicating usage. Passing just one will also just show help.
hitormiss shop fails with the following error:
[21:04:51] ERROR [red] Exception in command 'hitormiss shop'
╭───────────────────────────────────────── Traceback (most recent call last) ──────────────────────────────────────────╮
│ datapath\Red-DiscordBot\.venv\lib\site-packages\discord\ext\commands\core.py:229 in wrapped │
│ ❱ 229 ret = await coro(*args, **kwargs) │
│ Red-DiscordBot\data\flare\cogs\CogManager\cogs\hitormiss\main.py:312 in │
│ hom_shop │
│ ❱ 312 await view.start() │
│ Red-DiscordBot\data\flare\cogs\CogManager\cogs\hitormiss\views.py:180 in │
│ start │
│ ❱ 180 self.message = await self.ctx.send(content=content, embed=embed, view=self) │
│ datapath\Red-DiscordBot\redbot\core\commands\context.py:91 in send │
│ ❱ 91 return await super().send(content=content, **kwargs) │
│ datapath\Red-DiscordBot\.venv\lib\site-packages\discord\ext\commands\context.py:848 in send │
│ ❱ 848 return await super().send( │
│ datapath\Red-DiscordBot\.venv\lib\site-packages\discord\abc.py:1561 in send │
│ ❱ 1561 data = await state.http.send_message(channel.id, params=params) │
│ datapath\Red-DiscordBot\.venv\lib\site-packages\discord\http.py:744 in request │
│ ❱ 744 raise HTTPException(response, data) │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
HTTPException: 400 Bad Request (error code: 50035): Invalid Form Body
In embeds.0.thumbnail: Only dictionaries may be used in a ModelType
With embed_links off, hom create only sends a ping and nothing else. It will then correctly timeout
With embed_links off, the following commands error: hom stats
Sending of the JoinPing message will also fail if embed_links are off and an embed block is present.
Due to the above errors, functionality couldn’t be fully tested and will be done in a future iteration.
JoinPing:
With embed_links off, the following commands error: jpset show
Notes:
delnote & removenotes both accept no input, which may confuse users. The help indicates this, but requires them to run help first
notes.py:L303 uses the discord.py 1.7.x avatar method. This is not compatible with 2.x. You should use User.display_avatar.url instead.
allnotes:
Multiple get_member calls within same block.
Field title shows None for all users.
When you select a page, the close button will not work. It will throw Interaction Failed with the following traceback in the console.
Hey. Sorry for being so late but I have made all the changes necessary to fix the errors you faced. If any other errors are raised, please let me know again. Thanks!
Hey flare, really sorry for taking so long with these fixes.
As suggested, the problems in notes, JoinPing, HitOrMiss and Timer have been fixed.
Let me know if there’s anything left. Thank you very much.
