[APPROVED] Npc Cogs

Applications
#1

Discord Name: epic guy#0715

GitHub Repository (Must be V3): https://github.com/npc203/npc-cogs

Description: A simple bunch of cogs focused on utility and fun. A few cogs are hidden which are work in progress but others are working fine upto my knowledge.

Thanks in advance for reviewing my code. Cheers.

#4
#5

Hi epic guy#0715, thank you for your patience while I review your repo.

Commit hash at time of review - 7ecf12f9bc501e19f55f375b0bb2e5a35583c4be

bible

utils.py

  • Line 6: You should link to exactly where this is from in the RedHelpFormatter.

embedsteal

info.json

  • install_msg: This can be avoided by setting the min_bot_version to 3.4.6 which is the version of Red that included discord.py 1.6.0.

ghtools

ghtools.py

  • Line 37: There’s the possibility that the cog is loaded when Downloader is not loaded that will cause this to throw a KeyError when loaded.

Just a couple small things to fix and you’ll be good to go!

#6

Tysm for the sweet review! :smiley:

I’ve done the requested changes in 087f35f9fbbcadf05b21b3171d3d7dde007ed84c

  • Nuked ghtools and embedsteal, as they were mostly meant for my past self (will add them later after more refining).
  • Added the exact source reference for bible/utils.py.
#7

Thank you for making those changes. Marking this as approved!

#8